Skip to content

rustc: Fix some ThinLTO internalization #45215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2017
Merged

rustc: Fix some ThinLTO internalization #45215

merged 1 commit into from
Oct 15, 2017

Conversation

alexcrichton
Copy link
Member

First the addPreservedGUID function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the computeDeadSymbols return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195

@rust-highfive
Copy link
Contributor

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

r? @michaelwoerister

@alexcrichton alexcrichton force-pushed the thin-lto-reference-more branch from 5cd5a78 to e4b1536 Compare October 12, 2017 00:35
@michaelwoerister
Copy link
Member

Thank you, Alex!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2017

📌 Commit e4b1536 has been approved by michaelwoerister

@bors
Copy link
Collaborator

bors commented Oct 15, 2017

⌛ Testing commit e4b1536918a01ed6c78b056b37a70315e43a6d2b with merge 91c17361d07433ec9a11ed3ed023bb588984e89c...

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 15, 2017
@bors
Copy link
Collaborator

bors commented Oct 15, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 15, 2017

Legit. You forgot to move some auxiliary files 😄

[00:55:13] ---- [run-pass] run-pass/thinlto/thin-lto-inlines2.rs stdout ----
[00:55:13] 	
[00:55:13] error: aux-build `/checkout/src/test/run-pass/thinlto/auxiliary/thin-lto-inlines-aux.rs` source not found
[00:55:13] thread '[run-pass] run-pass/thinlto/thin-lto-inlines2.rs' panicked at 'explicit panic', /checkout/src/tools/compiletest/src/runtest.rs:1599:25
[00:55:13] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:55:13] 
[00:55:13] 
[00:55:13] failures:
[00:55:13]     [run-pass] run-pass/thinlto/thin-lto-inlines2.rs

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 15, 2017
@alexcrichton
rustc: Fix some ThinLTO internalization
2e1c4cd 
First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes rust-lang#45195
@alexcrichton alexcrichton force-pushed the thin-lto-reference-more branch from e4b1536 to 2e1c4cd Compare October 15, 2017 15:41
@alexcrichton
Copy link
Member Author

@bors: r=michaelwoerister

@bors
Copy link
Collaborator

bors commented Oct 15, 2017

📌 Commit 2e1c4cd has been approved by michaelwoerister

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2017
@bors
Copy link
Collaborator

bors commented Oct 15, 2017

⌛ Testing commit 2e1c4cd with merge 07adde34d967efad0b397f6dd6b4793d8ce49b7f...

@bors
Copy link
Collaborator

bors commented Oct 15, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 15, 2017

@bors retry

The build got spuriously cancelled?

@bors
Copy link
Collaborator

bors commented Oct 15, 2017

⌛ Testing commit 2e1c4cd with merge 29ed49f...

bors added a commit that referenced this pull request Oct 15, 2017
@bors
Auto merge of #45215 - alexcrichton:thin-lto-reference-more, r=michae…
29ed49f 
…lwoerister

rustc: Fix some ThinLTO internalization

First the `addPreservedGUID` function forgot to take care of "alias" summaries.
I'm not 100% sure what this is but the current code now matches upstream. Next
the `computeDeadSymbols` return value wasn't actually being used, but it needed
to be used! Together these should...

Closes #45195
@bors
Copy link
Collaborator

bors commented Oct 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: michaelwoerister
Pushing 29ed49f to master...

@bors bors merged commit 2e1c4cd into rust-lang:master Oct 15, 2017
@michaelwoerister
Copy link
Member

🎉

@petrochenkov petrochenkov mentioned this pull request Oct 16, 2017
Closed
@alexcrichton alexcrichton deleted the thin-lto-reference-more branch October 28, 2017 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @michaelwoerister @bors @kennytm @arielb1